stability: add fault-trigger client #326
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weekface
reviewed
Mar 18, 2019
| httpCli *http.Client | ||
| } | ||
|
|
||
| // Config defines for schrodinger client |
There was a problem hiding this comment.
Remove schrodinger literal?
| } | ||
|
|
||
| url := util.GenURL(fmt.Sprintf("%s/%s/vm/%s/start", c.cfg.Addr, api.APIPrefix, vmName)) | ||
| if _, err := c.get(url); err != nil { |
There was a problem hiding this comment.
Do all operations use the HTTP Get method?
There was a problem hiding this comment.
If the operation changes the state, I will replace theGet with Post in a sigle pr.
|
@weekface PTAL again, thanks! |
weekface
pushed a commit
to weekface/tidb-operator
that referenced
this pull request
Mar 21, 2019
* stability: add fault-trigger client
tennix
pushed a commit
that referenced
this pull request
Mar 21, 2019
* stability: add fault-trigger client
yahonda
pushed a commit
that referenced
this pull request
Dec 27, 2021
* add gcs br document * remove tab * add br parameter detail * fix tiny * remote unused parameter * modify doc via newest gcs doc * fix link * address comment * address comment * addrss comment * modify format * update toc * edit several headings * Update backup-to-gcs-using-br.md Co-authored-by: Ran <huangran@pingcap.com> Co-authored-by: DanielZhangQD <36026334+DanielZhangQD@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@weekface @zyguan @xiaojingchen PTAL